Fix missing request context (cookies/headers) in WebSocket callbacks#3815
Open
i-murray wants to merge 3 commits into
Open
Fix missing request context (cookies/headers) in WebSocket callbacks#3815i-murray wants to merge 3 commits into
i-murray wants to merge 3 commits into
Conversation
Propagate cookies, headers, args, path, remote, and origin from the WebSocket handshake onto the callback context in create_ws_context, mirroring the HTTP path. This fixes auth helpers (e.g. dash_enterprise_auth.get_user_data) failing over the WebSocket transport because callback_context.cookies/headers were empty.
i-murray
requested review from
KoolADE85,
T4rk1n,
camdecoster and
ndrezn
as code owners
|
3 tasks
Contributor
|
We have another PR #3819 that uses set_context_request on the fastapi part for the same effect, I think we need both solution consolidated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate cookies, headers, args, path, remote, and origin from the WebSocket handshake onto the callback context in create_ws_context, mirroring the HTTP path. This fixes auth helpers (e.g.
dash_enterprise_auth.get_user_data) failing over the WebSocket transport because callback_context.cookies/headers were empty.Closes #3814
Contributor Checklist
optionals
CHANGELOG.md